I found Edinburgh, to be clean and there are some lovely buildings but it was ruined by the the awful parking charges and the unfathomable oneway system.
Interesting. I wonder when you were there. I live just across the river from Edinburgh and would not dream of driving in. We have a very good bus service to Edinburgh and a reasonable train service. And the bus service in Edinburgh itself is superb!
But your reference to the one-way system intrigues me. For as long as I can remember now, Edinburgh has been blighted by the building of a tramway system the extent of which has been modified significantly since inception and which now will be limited to an airport to city centre service. And before that the Edinburgh District Council administration was significantly anti the motor car so did not do a great deal to enhance traffic flow.
Edinburgh is alright but I do prefer Glasgow, a more lively and vibrant city. And have I seen any mention of Dublin? Magnificent.